[Webkit-unassigned] [Bug 74196] [chromium] Delegate scroll events to the main thread when needed

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=74196





--- Comment #12 from James Robinson <jamesr at chromium.org>  2011-12-20 20:30:35 PST ---
(From update of attachment 120068)
View in context: https://bugs.webkit.org/attachment.cgi?id=120068&action=review

> Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:480
> +    if (!layerImpl)
> +        return false;

when can this parameter be null?

> Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:489
> +    if (!layerImpl->screenSpaceTransform().isInvertible())
> +        return false;
> +
> +    IntPoint contentPoint(layerImpl->screenSpaceTransform().inverse().mapPoint(viewportPoint));
> +    if (layerImpl->drawsContent() && !isContentPointWithinLayer(layerImpl, contentPoint))
> +        return false;
> +
> +    if (layerImpl->isInsideScrollableRegion(contentPoint))

there's not a whole lot (if anything) going on here that the CCLayerTreeHostImpl can do and the layer itself can't - all of the logic here is based on member functions of layerImpl. should this whole thing just be a member function of CCLayerImpl?

> Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:526
> +    if (!layerImpl->drawsContent() && (layerImpl->scrollable() || !layerImpl->scrollableRegion().isEmpty()))

at this point, this probably deserves at least a comment explaining why a given layer should or shouldn't be in the assembled list since it's no longer a list of non-drawable scrollable layers

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.