[Webkit-unassigned] [Bug 73533] Upstream the multipart feature in blackberry port

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=73533


Rob Buis <rwlbuis at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #119979|review?                     |review-
               Flag|                            |




--- Comment #17 from Rob Buis <rwlbuis at gmail.com>  2011-12-20 12:58:18 PST ---
(From update of attachment 119979)
View in context: https://bugs.webkit.org/attachment.cgi?id=119979&action=review

Looks good, some variable names need to be fixed though.

> Source/WebCore/platform/network/blackberry/NetworkJob.cpp:341
> +            bool needsAdd = true;

Can you come up with a clearer name?

> Source/WebCore/platform/network/blackberry/NetworkJob.cpp:342
> +            int replaceHedearIndex = 0;

I think replaceHeaderIndex is meant here.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.