[Webkit-unassigned] [Bug 73430] [EFL] Add pre-rendering implementation.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=73430


KwangHyuk <hyuki.kim at samsung.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hyuki.kim at samsung.com




--- Comment #9 from KwangHyuk <hyuki.kim at samsung.com>  2011-12-19 22:16:53 PST ---
> Source/WebKit/efl/ewk/ewk_private.h:51
> +#define EWK_ARGB_BYTES_SIZE 4

I suggest you to put this into ewk_tiled_backing_store.h since only backing store is using it.

> Source/WebKit/efl/ewk/ewk_tiled_backing_store.cpp:24
> +#include "ewk_private.h"

I think that this can be removed.

> Source/WebKit/efl/ewk/ewk_tiled_backing_store.cpp:1868
> +        viewRect->x, viewRect->y, viewRect->w, viewRect->h, tileWidth, tileHeight)) {

Do you have any reason these must have two lines ?

> Source/WebKit/efl/ewk/ewk_tiled_backing_store.cpp:1874
> +        renderRect->x, renderRect->y, renderRect->w, renderRect->h, tileWidth, tileHeight)) {

Ditto.

> Source/WebKit/efl/ewk/ewk_view.h:1257
> + * This is an alternative method to pre-render the view area.

may you mean "pre-render the view area" -> "pre-render around the view area".

> Source/WebKit/efl/ewk/ewk_view_tiled.cpp:237
> +static inline void _ewk_view_tiled_rect_collision_resolve(int direction, int* destinationX, int* destinationY, int* destinationWidth, int* destinationHeight, int sourceX, int sourceY, int sourceWidth, int sourceHeight)

As no new assignment for destinationWidth and destinationHeight was found, why should it be pointer ?

> Source/WebKit/efl/ewk/ewk_view_tiled.cpp:277
> +        && smartData->previousView.zoom == currentViewZoom) {

Do you have any reason these must have three lines ?
currentViewZoom is just available from this line, but you put the code to bring it from the beginning of the function.
I suggest you to move calling of it into somewhere near the this condition block.

> Source/WebKit/efl/ewk/ewk_view_tiled.cpp:292

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.