[Webkit-unassigned] [Bug 74179] [EFL] Context menu restore for WebKit-EFL

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=74179





--- Comment #5 from Gyuyoung Kim <gyuyoung.kim at samsung.com>  2011-12-19 19:33:40 PST ---
(From update of attachment 118580)
View in context: https://bugs.webkit.org/attachment.cgi?id=118580&action=review

Personally, I like this patch. EFL port needs context menu so far. :-)

> Source/WebKit/efl/ewk/ewk_private.h:170
> +void ewk_context_menu_item_append(Ewk_Context_Menu_Core* o, const WebCore::ContextMenuItem& core);

We don't use efl variable name style in internal functions. Change o with menu or coreMenu.

> Source/WebKit/efl/ewk/ewk_private.h:173
> +void ewk_context_menu_core_vector_get(Ewk_Context_Menu_Core* o, Vector<Ewk_Context_Menu_Item*>& itemsVector);

ditto.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.