[Webkit-unassigned] [Bug 74693] Optimize with memcpy instead of copying frame by frame in Realtimeanalyser::doFFTAnalysis

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=74693





--- Comment #6 from Wei James <james.wei at intel.com>  2011-12-19 16:52:38 PST ---
(From update of attachment 119717)
View in context: https://bugs.webkit.org/attachment.cgi?id=119717&action=review

>> Source/WebCore/webaudio/RealtimeAnalyser.cpp:162
>> +        memcpy(tempP, inputBuffer + writeIndex - fftSize + InputBufferSize, sizeof(*tempP) * (fftSize - writeIndex));
> 
> Does this handle wrapping the index as the original code did?  It seems to me that writeIndex (m_writeIndex) could be as large as InputBufferSize - 1, so the memcpy might be reading past the end of the inputBuffer.

this memcpy is under the if(writeIndex < fftSize) statement. the case you mentioned is under else statement. thanks

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.