[Webkit-unassigned] [Bug 74893] New: [chromium] Make sure rootDamageRect gets passed to renderer

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=74893

           Summary: [chromium] Make sure rootDamageRect gets passed to
                    renderer
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
        OS/Version: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Layout and Rendering
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: shawnsingh at chromium.org
                CC: jamesr at chromium.org, enne at google.com,
                    backer at chromium.org


In the process of refactoring, the root damage rect got "disconnected" from where it is used to perform the partial swap.  The fix is very straightforward, and works fine.  However, I would like to add a unit test to make sure this does not happen again.  An effective unit test needs to mock the "getExtensions()" accessor, so we can pretend that partial swap is supported.  Currently getExtensions() is implemented as non-virtual in un-mockable GraphicsContext3DPrivate.

Is it OK to move the implementation of getExtensions() from GraphicsContext3DPrivate into WebGraphicsContext3D, where we can make it virtual and mock-able?  or is there some reason not to do this?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.