[Webkit-unassigned] [Bug 68969] need iframe shim support for Gtk webkit

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=68969





--- Comment #16 from Martin Robinson <mrobinson at webkit.org>  2011-12-19 14:32:55 PST ---
(From update of attachment 111723)
View in context: https://bugs.webkit.org/attachment.cgi?id=111723&action=review

I think with the typo fix and the minor change below this patch looks okay.

> Source/WebCore/plugins/gtk/PluginViewGtk.cpp:586
> +            cairo_region_t* cutOutRegion = cairo_region_create_rectangle(&cutOutRect);
> +            cairo_region_subtract(clipRegion, cutOutRegion);

Why not just do:
cairo_rectangle_int_t cutOutRect = cutOutRects[i];
cairo_region_subtract_rectangle(clipRegion, cutOutRegion);

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.