[Webkit-unassigned] [Bug 61915] [EFL][WK2] Add efl port's ewk_view files
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sun Dec 18 22:30:29 PST 2011
https://bugs.webkit.org/show_bug.cgi?id=61915
--- Comment #46 from EunMi Lee <eunmi15.lee at samsung.com> 2011-12-18 22:30:28 PST ---
Thank you for your comment, Gyuyoung.
I will update patch after changing all c style type casting to c++ style.
(In reply to comment #45)
> (From update of attachment 119808 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=119808&action=review
>
> > Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:175
> > + Ewk_View_Smart_Data* smartData = (Ewk_View_Smart_Data*)data;
>
> Do not use c type casting. Please use C++ casting.
>
> > Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:183
> > + Ewk_View_Smart_Data* smartData = (Ewk_View_Smart_Data*)data;
>
> ditto.
>
> > Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:191
> > + Evas_Event_Mouse_Wheel* wheelEvent = (Evas_Event_Mouse_Wheel*)eventInfo;
>
> ditto.
>
> > Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:192
> > + Ewk_View_Smart_Data* smartData = (Ewk_View_Smart_Data*)data;
>
> ditto.
>
> > Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:200
> > + Evas_Event_Mouse_Down* downEvent = (Evas_Event_Mouse_Down*)eventInfo;
>
> ditto.
>
> > Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:201
> > + Ewk_View_Smart_Data* smartData = (Ewk_View_Smart_Data*)data;
>
> ditto.
>
> > Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:209
> > + Evas_Event_Mouse_Up* upEvent = (Evas_Event_Mouse_Up*)eventInfo;
>
> ditto.
>
> > Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:218
> > + Evas_Event_Mouse_Move* moveEvent = (Evas_Event_Mouse_Move*)eventInfo;
>
> ditto.
>
> > Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:219
> > + Ewk_View_Smart_Data* smartData = (Ewk_View_Smart_Data*)data;
>
> ditto.
>
> > Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:227
> > + Evas_Event_Key_Down* downEvent = (Evas_Event_Key_Down*)eventInfo;
>
> ditto.
>
> > Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:228
> > + Ewk_View_Smart_Data* smartData = (Ewk_View_Smart_Data*)data;
>
> ditto.
>
> > Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:236
> > + Evas_Event_Key_Up* upEvent = (Evas_Event_Key_Up*)eventInfo;
>
> ditto.
>
> > Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:237
> > + Ewk_View_Smart_Data* smartData = (Ewk_View_Smart_Data*)data;
>
> ditto.
>
> > Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:248
> > + (Ewk_View_Private_Data*)calloc(1, sizeof(Ewk_View_Private_Data));
>
> ditto.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list