[Webkit-unassigned] [Bug 74783] [QT] WebGL can not make the frame buffer with the stencil buffer.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=74783


Noam Rosenthal <noam.rosenthal at nokia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #119720|review?, commit-queue?      |review-, commit-queue-
               Flag|                            |




--- Comment #3 from Noam Rosenthal <noam.rosenthal at nokia.com>  2011-12-18 16:25:05 PST ---
(From update of attachment 119720)
View in context: https://bugs.webkit.org/attachment.cgi?id=119720&action=review

Good patch, see my usual changelog nitpicks

> Source/WebCore/ChangeLog:11
> +        GraphicsContext3DQt was able to make the frame buffer with the depth buffer and
> +        the depth-stencil buffer, not with the stencil buffer.
> +        In the case QT_OPENGL_ES_2 is defined, GraphicsContext3DQt was able to make only
> +        the frame buffer with the depth buffer.
> +        This makes GraphicsContext3DQt make the frame buffer with any combination of the
> +        depth buffer and the stencil buffer.

Proposing alternative wording for the Changelog:

When initializing a framebuffer in OpenGL ES 2, we need to initialize the depth and stencil buffers separately, as opposed to the combined depth-stencil buffer we initialize for desktop GL.

> Source/WebCore/ChangeLog:14
> +

You should mention that existing WebGL tests cover this.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.