[Webkit-unassigned] [Bug 74693] Optimize with memcpy instead of copying frame by frame in Realtimeanalyser::doFFTAnalysis

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=74693





--- Comment #4 from Wei James <james.wei at intel.com>  2011-12-17 00:41:41 PST ---
(In reply to comment #2)
> (From update of attachment 119579 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=119579&action=review
> 
> > Source/WebCore/webaudio/RealtimeAnalyser.cpp:162
> > +        memcpy(tempP, inputBuffer + writeIndex - fftSize + InputBufferSize, sizeof(float) * (fftSize - writeIndex));
> 
> I think sizeof(*tempP) is better than sizeof(float).

thanks for the review. patch updated.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.