[Webkit-unassigned] [Bug 74778] New: *Command.h files shouldn't be exported to WebKit layer

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=74778

           Summary: *Command.h files shouldn't be exported to WebKit layer
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
        OS/Version: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: HTML Editing
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: rniwa at webkit.org
                CC: darin at apple.com, mrowe at apple.com, enrica at apple.com


>From https://bugs.webkit.org/show_bug.cgi?id=74490

 Comment #36 From Mark Rowe (bdash) 2011-12-16 20:20:42 PST (-) [reply] 
The following headers are in WebCore.framework/PrivateHeaders and include CompositeEditCommand.h:

ApplyBlockElementCommand.h
DeleteSelectionCommand.h
MoveSelectionCommand.h
ReplaceSelectionCommand.h
TypingCommand.h

Any and all of these will cause similar build failures if used.

...

 Comment #40 From Ryosuke Niwa 2011-12-16 20:30:27 PST (-) [reply] 
Oops, it appears that _insertParagraphSeparatorInQuotedContent is calling TypingCommand::insertParagraphSeparatorInQuotedContent :( I'll have to add CompositeEditCommand.h back to the framework.

WebKit layer shouldn't be including any one of these Command files.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.