[Webkit-unassigned] [Bug 74071] [Chromium] Chromium should have EditorClientImpl::checkTextOfParagraph

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=74071


Darin Fisher (:fishd, Google) <fishd at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #119126|review?                     |review+, commit-queue-
               Flag|                            |




--- Comment #13 from Darin Fisher (:fishd, Google) <fishd at chromium.org>  2011-12-16 16:16:38 PST ---
(From update of attachment 119126)
View in context: https://bugs.webkit.org/attachment.cgi?id=119126&action=review

> Source/WebKit/chromium/public/WebTextCheckingResult.h:48
> +    // TODO(shinyak): Should be removed after we confirm Chromium does not use it.

nit: WebKit style is to use FIXME instead of TODO(user)

> Source/WebKit/chromium/public/WebTextCheckingResult.h:94
> +    Error error; // TODO(shinyak): Should be removed after we confirm Chromium does not use it.

TODO(user) -> FIXME

> Source/WebKit/chromium/public/WebTextCheckingResult.h:98
> +    WebVector<WebGrammarDetail> details;

it seems like there is potentially a lot of copying of data here.  have you
considered transforming WebCore::GrammarDetail and WebCore::TextCheckingResult
to be reference counted so that we can just create WebPrivatePtr<>-style wrappers
for them at the API boundary?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.