[Webkit-unassigned] [Bug 74133] Convert some fast/regions pixel tests to reftests

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Dec 16 11:42:55 PST 2011


Tony Chang <tony at chromium.org> changed:

           What    |Removed                     |Added
 Attachment #119640|review?, commit-queue?      |review-, commit-queue-
               Flag|                            |

--- Comment #15 from Tony Chang <tony at chromium.org>  2011-12-16 11:42:55 PST ---
(From update of attachment 119640)
View in context: https://bugs.webkit.org/attachment.cgi?id=119640&action=review

> LayoutTests/ChangeLog:4
> +        updates
> +

Did you mean to include these lines?  Maybe just remove them.

> LayoutTests/fast/regions/webkit-flow-inlines-dynamic.html:39
>  <div id="content">

Could you add some text saying what the test is testing?  E.g., The text in the test should not get out of the region.

> LayoutTests/fast/regions/webkit-flow-inlines-dynamic.html:-58
> -<script>
> -document.body.offsetWidth;
> -document.getElementById('test').appendChild(document.createTextNode(" Here is some added content that will mess things up, since it shoves things down."));

Is this an important part of the test?  Why is it being removed?

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list