[Webkit-unassigned] [Bug 73773] [WK2][GTK] WebSettings support in MiniBrowser

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=73773





--- Comment #5 from Carlos Garcia Campos <cgarcia at igalia.com>  2011-12-16 01:41:31 PST ---
(From update of attachment 117791)
View in context: https://bugs.webkit.org/attachment.cgi?id=117791&action=review

I know this has been copied from GtkLauncher, so maybe can land this, and then fix the possible issus in GtkLauncher and MiniBrowser at the same time.

> Tools/MiniBrowser/gtk/main.c:87
> +        if (value && g_ascii_strcasecmp(value, "true") && strcmp(value, "1"))

I don't undertand this line g_ascii_strcasecmp(value, "true") && strcmp(value, "1"), I don't know what the intention is, but the value can't be "true" and "1".

> Tools/MiniBrowser/gtk/main.c:144
> +        return 0;

We can use NULL in C.

> Tools/MiniBrowser/gtk/main.c:152
> +        if (!param || !(param->flags & G_PARAM_WRITABLE))

I'm not sure we need this, all properties in webkit settings are READWRITE. But if we leave the check we should skip also construct only properties, since you can't do g_object_set on them.

> Tools/MiniBrowser/gtk/main.c:157
> +        if (gParamType == G_TYPE_BOOLEAN || gParamType == G_TYPE_STRING || gParamType == G_TYPE_INT
> +            || gParamType == G_TYPE_FLOAT) {

I would use a help function here, and continue if the type is not valid, 

if (!paramTypeIsSupported(gParamType))
    continue;

> Tools/MiniBrowser/gtk/main.c:177
> +static gboolean addSettingsGroupToContext(GOptionContext *context, WebKitSettings* webkitSettings)

WebKitSettings* webkitSettings -> WebKitSettings *webkitSettings

> Tools/MiniBrowser/gtk/main.c:208
> +        webkitSettings = 0;

We can use NULL in C.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.