[Webkit-unassigned] [Bug 74383] Upstream PlatformMouseEvent and LocalizedStrings into WebCore/platform/blackberry

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Dec 15 23:51:35 PST 2011


--- Comment #10 from Mary Wu <mary.wu at torchmobile.com.cn>  2011-12-15 23:51:34 PST ---
(In reply to comment #8)
> (From update of attachment 119381 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=119381&action=review
> Thanks Mary for updating the patch. Notice that most of these these methods build a WTF::String object from a C-string. We should probably leak the WTF::String objects if these methods are called frequently instead of building a WTF::String object on each method call.

yes, thanks for the comments...those are used in file buttons and context menu which we seldom used, and looks other portings didn't leak WTF::String objects either. So I think maybe we could keep it is here for now.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list