[Webkit-unassigned] [Bug 73397] [BlackBerry] Upstream BlackBerry porting of pluginView

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=73397





--- Comment #16 from Charles Wei <charles.wei at torchmobile.com.cn>  2011-12-15 22:27:36 PST ---
(In reply to comment #14)
> (From update of attachment 119167 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=119167&action=review
> 
> > Source/WebCore/plugins/blackberry/PluginViewBlackBerry.cpp:532
> > +            npTouchEvent.points[i].touchId = touchItem->identifier();
> > +            npTouchEvent.points[i].clientX = touchItem->pageX() - frameRect().x();
> > +            npTouchEvent.points[i].clientY = touchItem->pageY() - frameRect().y();
> > +            npTouchEvent.points[i].screenX = touchItem->screenX();
> > +            npTouchEvent.points[i].screenY = touchItem->screenY();
> > +            npTouchEvent.points[i].pageX = touchItem->pageX();
> > +            npTouchEvent.points[i].pageY = touchItem->pageY();
> 
> Although the compiler will probably cache npTouchEvent.points, you may want to consider dereferencing touchPoints (i.e. touchPoints[i]) instead of dereferencing points and then dereferencing the ith point. That is, I would have written these lines as:
> 
> touchPoints[i]. touchId = = touchItem->identifier();
> touchPoints[i].clientX = touchItem->pageX() - frameRect().x();
> ...
> touchPoints[i].pageY = touchItem->pageY();


Thanks, Daniel.  Your comments have been addressed and the patch has been landed. Thanks again for your review and comments.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.