[Webkit-unassigned] [Bug 74383] Upstream PlatformMouseEvent and LocalizedStrings into WebCore/platform/blackberry

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=74383


Daniel Bates <dbates at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #119381|review?                     |review+
               Flag|                            |




--- Comment #8 from Daniel Bates <dbates at webkit.org>  2011-12-15 19:18:20 PST ---
(From update of attachment 119381)
View in context: https://bugs.webkit.org/attachment.cgi?id=119381&action=review

Thanks Mary for updating the patch. Notice that most of these these methods build a WTF::String object from a C-string. We should probably leak the WTF::String objects if these methods are called frequently instead of building a WTF::String object on each method call.

> Source/WebCore/platform/blackberry/LocalizedStringsBlackBerry.cpp:587
> +}

Do we need to use String::fromUTF8 here? It seems like it would be sufficient to write this as:

return String(", ...");

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.