[Webkit-unassigned] [Bug 74169] Upstream PageClientBlackBerry.h into WebCore/platform/blackberry

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Dec 15 16:14:42 PST 2011


https://bugs.webkit.org/show_bug.cgi?id=74169


Daniel Bates <dbates at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #119145|review?                     |review+
               Flag|                            |




--- Comment #21 from Daniel Bates <dbates at webkit.org>  2011-12-15 16:14:42 PST ---
(From update of attachment 119145)
View in context: https://bugs.webkit.org/attachment.cgi?id=119145&action=review

> Source/WebCore/platform/blackberry/PageClientBlackBerry.h:34
> +namespace BlackBerry {
> +namespace Platform {
> +class NetworkStreamFactory;
> +
> +namespace Graphics {
> +class Window;
> +}
> +
> +}
> +}

>From talking with Dave Levin today on IRC, this should be written as:

namespace BlackBerry {
    namespace Platform {
        class NetworkStreamFactory;
        namespace Graphics {
            class Window;
        }
    }
}

This formatting makes the forward declarations stand out since they are indented. Some additional remarks on this formatting are mentioned in the description and comments of bug #36760. The comments in bug #36760 and the discussion from Dave Levin seemed to imply that the remarks on namespace indentation in <http://www.webkit.org/coding/coding-style.html> pertain to a namespace that contains class/struct definitions. That is, the code style guidelines don't pertain to a namespace that only lists forward declarations (as is the case here).

We should look to clarify this on webkit-dev.

> Source/WebCore/platform/blackberry/PageClientBlackBerry.h:40
> +namespace WebCore {
> +class IntRect;
> +class IntSize;
> +class PluginView;
> +}

Similarly, since this namespace only lists forward declarations it should be written as:

namespace WebCore {
    class IntRect;
    class IntSize;
    class PluginView;
}

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list