[Webkit-unassigned] [Bug 74648] DOM4: prepend, append, before, after & replace

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=74648


Ojan Vafai <ojan at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |abarth at webkit.org




--- Comment #1 from Ojan Vafai <ojan at chromium.org>  2011-12-15 14:23:11 PST ---
(In reply to comment #0)
> DOM4 has these methods which all takes var args of union types
> 
> // NEW (using experimental IDL)
>   void prepend(Node | DOMString... nodes);
>   void append(Node | DOMString... nodes);
>   void before(Node | DOMString... nodes);
>   void after(Node | DOMString... nodes);
>   void replace(Node | DOMString... nodes);
> 
> The way I was envisioning implementing these was to add methods to Node.h that takes a WTF::Vector<WebCore::NodeOrString>. The class NodeOrString would have isNode/toNode and isString/toString methods and there would be one constructor per type. The binding code would check the type and call the right constructor.

I would have isNode/node and isString/string.

> Does this seem reasonable?

Yes.

> Is it worth adding support for this in the code generators at this point?

Yes.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.