[Webkit-unassigned] [Bug 74595] [GTK] Add WebKitWindowProperties to WebKit2 GTK+ API

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=74595





--- Comment #5 from Carlos Garcia Campos <cgarcia at igalia.com>  2011-12-15 06:24:16 PST ---
(In reply to comment #3)
> (From update of attachment 119400 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=119400&action=review
> 
> I like the rename to WindowProperties, it certainly caused some misunderstanding before, being called features. I love how good our API test coverage is becoming, WebKit2GTK+ will shine, you're doing a great job Carlos! =)

Thanks! Unit tests are indeed quite useful to find bugs early.

> I was thinking about getWindowFrame. I remember at some point considering, in webkit1, whether we should report the actual window size or the knowledge WebWindowFeatures had of it, for some sites had terrible checks like "while (size != desired_size) request_size_change(desired_size)", or something like that, but I don't think we did anything regarding that, and things seem to be working fine, so this one also looks fine to me.

Well, the window features size is what you should use for the window, while getWindowFrame is the actual size of the window, it might be different. 

> > Source/WebKit2/UIProcess/API/gtk/WebKitWindowProperties.cpp:452
> > + * Get the geometry that the window should have on the screen when shown.
> 
> Nit: should be Gets, since we're talking about the function. Also, s/that//, I think.

I used Get for consistency with WebKitSettings API docs that uses Get/Set everywhere, but I'm not english expert.

> > Source/WebKit2/UIProcess/API/gtk/WebKitWindowProperties.h:61
> > +webkit_window_properties_get_geometry            (WebKitWindowProperties *window_properties,
> > +                                                  GdkRectangle           *geometry);
> 
> Should we use cairo_rectangle_int_t here, rather than GdkRectangle? GdkRectangle is currently a typedef to the cairo type, and we seem to be gradually moving towards using the cairo types directly. I'll ask the GTK+ people and report back here.

I used GdkRecangle here because it's a boxed property and I need to use GDK_TYPE_RECTANGLE, I could use cairo_rectangle in public API but it might be confusing because API docs will say the property is a GdkRectangle

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.