[Webkit-unassigned] [Bug 74595] [GTK] Add WebKitWindowProperties to WebKit2 GTK+ API

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=74595


Gustavo Noronha (kov) <gns at gnome.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #119400|review?                     |review+
               Flag|                            |




--- Comment #3 from Gustavo Noronha (kov) <gns at gnome.org>  2011-12-15 06:06:41 PST ---
(From update of attachment 119400)
View in context: https://bugs.webkit.org/attachment.cgi?id=119400&action=review

I like the rename to WindowProperties, it certainly caused some misunderstanding before, being called features. I love how good our API test coverage is becoming, WebKit2GTK+ will shine, you're doing a great job Carlos! =)

I was thinking about getWindowFrame. I remember at some point considering, in webkit1, whether we should report the actual window size or the knowledge WebWindowFeatures had of it, for some sites had terrible checks like "while (size != desired_size) request_size_change(desired_size)", or something like that, but I don't think we did anything regarding that, and things seem to be working fine, so this one also looks fine to me.

> Source/WebKit2/UIProcess/API/gtk/WebKitWindowProperties.cpp:452
> + * Get the geometry that the window should have on the screen when shown.

Nit: should be Gets, since we're talking about the function. Also, s/that//, I think.

> Source/WebKit2/UIProcess/API/gtk/WebKitWindowProperties.h:61
> +webkit_window_properties_get_geometry            (WebKitWindowProperties *window_properties,
> +                                                  GdkRectangle           *geometry);

Should we use cairo_rectangle_int_t here, rather than GdkRectangle? GdkRectangle is currently a typedef to the cairo type, and we seem to be gradually moving towards using the cairo types directly. I'll ask the GTK+ people and report back here.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.