[Webkit-unassigned] [Bug 74528] [Qt] Support requestAnimationFrame API

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=74528





--- Comment #3 from Simon Hausmann <hausmann at webkit.org>  2011-12-15 03:58:23 PST ---
(From update of attachment 119274)
View in context: https://bugs.webkit.org/attachment.cgi?id=119274&action=review

> Source/WebCore/Target.pri:3325
> +contains(DEFINES, ENABLE_REQUEST_ANIMATION_FRAME=1) {
> +    !v8 {
> +        SOURCES += \
> +            bindings/js/JSRequestAnimationFrameCallbackCustom.cpp
> +    }
> +
> +    SOURCES += \
> +        dom/ScriptedAnimationController.cpp
> +
> +    HEADERS += \
> +        dom/ScriptedAnimationController.h
> +}

I believe that you can add these files to the build unconditionally. They follow the common WebKit pattern that all files are buildable and contain corresponding preprocessor guards. The files in question here appear to contain them, so they will compile with and without the feature enabled.

So AFAICS we don't _need_ to make Target.pri more complex :)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.