[Webkit-unassigned] [Bug 74078] [Qt] Shared memory should use SHM instead of tmpdir

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=74078





--- Comment #8 from Simon Hausmann <hausmann at webkit.org>  2011-12-15 00:30:10 PST ---
(From update of attachment 118377)
View in context: https://bugs.webkit.org/attachment.cgi?id=118377&action=review

> Source/WebKit2/Platform/unix/SharedMemoryUnix.cpp:125
> +#if PLATFORM(QT)
> +    while ((fileDescriptor = shm_open(tempNameC, O_CREAT | O_CLOEXEC | O_RDWR, S_IRUSR | S_IWUSR)) == -1) {
> +        if (errno != EINTR)
> +            return 0;
> +    }
> +#else
>      while ((fileDescriptor = mkstemp(tempNameC)) == -1) {
>          if (errno != EINTR)
>              return 0;

It's kind of silly that Qt uses shm_open and the others use mkstemp - there is nothing Qt specific here. We should simply be using shm_open/shm_unlink for SharedMemoryUnix.cpp.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.