[Webkit-unassigned] [Bug 74549] Web Inspector: Switch to type-safe JSON ConsoleMessage.cpp, InspectorDOMAgent.cpp, InspectorDebuggerAgent.cpp, ScriptCallFrame.cpp

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Dec 15 00:18:07 PST 2011


https://bugs.webkit.org/show_bug.cgi?id=74549


Pavel Feldman <pfeldman at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #119311|review?                     |review+
               Flag|                            |




--- Comment #3 from Pavel Feldman <pfeldman at chromium.org>  2011-12-15 00:18:06 PST ---
(From update of attachment 119311)
View in context: https://bugs.webkit.org/attachment.cgi?id=119311&action=review

Great job!

> Source/WebCore/inspector/ScriptCallFrame.cpp:67
> +            String::number(m_lineNumber))

Please do a drive-by fix to the protocol itself instead of this workaround. You can also fix the Inspector-0.1.json in this case - it is clearly a typo.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list