[Webkit-unassigned] [Bug 74510] Add ENABLE(HARMONY) and --harmony

Wed Dec 14 20:59:21 PST 2011

https://bugs.webkit.org/show_bug.cgi?id=74510

Gavin Barraclough <barraclough at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #119232|review?                     |review-
               Flag|                            |

--- Comment #2 from Gavin Barraclough <barraclough at apple.com>  2011-12-14 20:59:21 PST ---
(From update of attachment 119232)
I'm not sure that this makes sense as a global setting.  Some scripts may be harmonious, others not, so we're going to need harmony to be enabled on a source-by-source basis, not as a global option.  I don't think a 'harmony' flag in the JSC framework is needed.  The command shell may want to look for this flag as an instruction as to how the source it reads in should be interpreted - to create SourceCode/SourceProvider objects with an ES6 flag set (perhaps this should be a new default-to-false argument to makeSource).

I don't know what you'd do with a harmonyBlockScoping global setting - for ES5 scripts it only makes sense to not use harmony scoping rules, for ES6 scripts it only makes sense to do so.

We generally don't accept changes that are not complete in their own right, and are effectively dead code - which this is.  Whilst we do like to see changes broken down into smaller patches where sensible, I'd suggest that this is a small enough change that it may be wiser to introduce this alongside the first actual harmony feature implemented.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.