[Webkit-unassigned] [Bug 74491] Upstream FileSystemBlackBerry.cpp into WebCore/platform/blackberry

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=74491





--- Comment #5 from Leo Yang <leo.yang at torchmobile.com.cn>  2011-12-14 20:03:13 PST ---
(From update of attachment 119363)
View in context: https://bugs.webkit.org/attachment.cgi?id=119363&action=review

Informal review.

> Source/WebCore/ChangeLog:8
> +        We get most of FileSystem implementations from posix porting.        

How about changing this line to "Because we are using most of file system implementations from the POSIX porting we only need to implement the left functions." ?
I would add an empty line after this line.

> Source/WebCore/platform/blackberry/FileSystemBlackBerry.cpp:39
> +bool unloadModule(PlatformModule)
> +{
> +    return false;

Don't we use this API? Why not implement?

> Source/WebCore/platform/blackberry/FileSystemBlackBerry.cpp:44
> +    return "";

Couldn't we implement this on the BlackBerry/QNX platform?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.