[Webkit-unassigned] [Bug 74535] [chromium] Add postCancellable[Delayed]Task to CCThread

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=74535





--- Comment #9 from James Robinson <jamesr at chromium.org>  2011-12-14 16:50:14 PST ---
CCScopedThreadProxy is definitely overkill if you're posting a task to run on the same thread. CCDelayBasedTimeSource is an interesting use case and I'll definitely think about it.

I don't think that fling animation (or animations in general) are a good use case for this mechanism, though - they should work by requesting a new frame and then receiving callbacks from the scheduler or animation controller. Then cancellation happens by simply removing the target from the list of things the scheduler / animation controller / whatever considers on each tick. For example WebCompositorInputHandleImpl (which implements CCInputHandler) receives a willDraw() callback which is the appropriate place to update fling animation states, if we had fling animations driven from WebCompositorInputHandleImpl.

Chromium's base::CancelableCallback and WebKit's WebCore::Timer take two other approaches to having cancelable delayed tasks. Have you looked at those and are there specific reasons you went with this handle approach instead of one of those?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.