[Webkit-unassigned] [Bug 74535] [chromium] Add postCancellable[Delayed]Task to CCThread

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=74535





--- Comment #3 from Nat Duca <nduca at chromium.org>  2011-12-14 13:37:53 PST ---
(From update of attachment 119284)
View in context: https://bugs.webkit.org/attachment.cgi?id=119284&action=review

Lets file a new webkit bug now for unit tests for this. You can write those afterward since you've been really nice in doing this upstream in the first place.

> Source/WebCore/WebCore.gypi:3638
> +            'platform/graphics/chromium/cc/CCTaskHandle.cpp',

You can put this the code for these in CCThread.h/cpp  if you want. I'm neutral either way.

> Source/WebCore/platform/graphics/chromium/cc/CCTaskHandle.h:40
> +class CCTaskHandle {

Put a comment above the class decl explain what this is used for, how it is used, etc.

> Source/WebCore/platform/graphics/chromium/cc/CCTaskHandle.h:46
> +    void clear();

Cancel? Since we're calling it postCancellable

> Source/WebCore/platform/graphics/chromium/cc/CCTaskHandle.h:69
> +    // We don't hold the ownership of the TaskWrapper. This is a weak pointer which will be reset to null once the TaskWrapper got destructed by the task queue.

The second setence is most of the value. No need to point out that we don't hold ownership.

> Source/WebCore/platform/graphics/chromium/cc/CCThread.h:57
>  

//comments to explain usage?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.