[Webkit-unassigned] [Bug 74428] Create reftest for outline-sides-in-region

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=74428


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #119080|review?                     |review+
               Flag|                            |




--- Comment #3 from Darin Adler <darin at apple.com>  2011-12-14 11:00:43 PST ---
(From update of attachment 119080)
View in context: https://bugs.webkit.org/attachment.cgi?id=119080&action=review

> LayoutTests/fast/regions/outline-sides-in-region-expected.html:15
> +	<div id="region">
> +		<div id="source">

I suggest omitting the ids.

> LayoutTests/fast/regions/outline-sides-in-region.html:10
> +	/* There appears to be a bug in margin-top collapsing for the first region.
> +	 That issue will be filed separately. For now, forcing margin-top:0 allows us
> +	to create an accurate reftest for outline drawing. */

Strange indentation here. Also, we normally use // comments rather than /* comments.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.