[Webkit-unassigned] [Bug 73544] [EFL] Add Web Notification feature for Efl port

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Dec 14 03:30:44 PST 2011


https://bugs.webkit.org/show_bug.cgi?id=73544





--- Comment #16 from Grzegorz <g.czajkowski at samsung.com>  2011-12-14 03:30:44 PST ---
(In reply to comment #15)
> > > Source/WebKit/efl/WebCoreSupport/NotificationPresenterClientEfl.h:53
> > > +    Evas_Object* m_view;
> 
> >I would rather change an order here. Please define members of class first then methods.
> 
> Could you show me a example please?
> I can't find private member function from WebCoreSupport but 
> I think members are first then methods in the WebCore.
> Please see a DOMWindow.h.
> 
> How do you think about this?
> 

In private section you've defined sendEvent(...) method first and then variables.
I'd rather reverse them.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list