[Webkit-unassigned] [Bug 53644] [GTK] editing/deleting/5408255.html results are incorrect

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Dec 14 02:41:34 PST 2011


https://bugs.webkit.org/show_bug.cgi?id=53644





--- Comment #12 from Philippe Normand <pnormand at igalia.com>  2011-12-14 02:41:33 PST ---
(From update of attachment 118807)
View in context: https://bugs.webkit.org/attachment.cgi?id=118807&action=review

> Source/WebCore/platform/graphics/gtk/ImageGtk.cpp:78
>  static const char* getWebKitDataDirectory()

I think it would make sense to return a smart pointer here now.

> Source/WebCore/platform/graphics/gtk/ImageGtk.cpp:151
> +        GOwnPtr<gchar> glibFileName(g_build_filename(getWebKitDataDirectory(), imageName.get(), NULL));

I think this introduces a leak of the string returned by getWebKitDataDirectory().

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list