[Webkit-unassigned] [Bug 74286] [Chromium] Use decoding swizzle only on libjpeg-turbo 1.1.90+

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Dec 14 00:52:44 PST 2011


https://bugs.webkit.org/show_bug.cgi?id=74286





--- Comment #7 from PaweĊ‚ Hajdan, Jr. <phajdan.jr at chromium.org>  2011-12-14 00:52:43 PST ---
(In reply to comment #5)
> JPEGImageDecoder.cpp is used not only for Chromium but also for all WebKit-based browsers.

Just wait for all those WebKit-based browsers used in the Linux land to hit the same problem. They just update WebKit much more rarely than Chromium does. I'm pretty sure they'd be affected in the same way.

> Unfortunately, as written in my comment, we do not have good
> options to satisfy his request for now and we need to find good alternatives, such as:
> * Disable the swizzle code on all platforms:
> * Enable the swizzle code only when we compile WebKit with a USE() macro;
> * Enable the swizzle code only when we compile WebKit with use_system_jpeg=0.

Provided we get -DUSE_SYSTEM_LIBJPEG in that WebKit file when -Duse_system_jpeg=1 is passed (I haven't checked that, and it's obviously fixable by ensuring proper gyp dependencies are in place).

For me, all of those options are fine. You probably want something that'd make it enabled for Google Chrome, so my best bet is a USE() macro, controlled by use_system_jpeg on the Chrome side.

(In reply to comment #6)
> Over in Gentoo land, we could introduce a portage use flag
> that would translate into a gyp definition and enable or disable the "swizzle" code explicitly.

Note: I'm not enthusiastic about such a flag. IMO it's an unnecessary complication.

> Other distros could make the decision when they build packages.

Sounds good. In Gentoo though I'd _probably_ prefer to have the swizzle code off, until the vanilla libjpeg also supports it.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list