[Webkit-unassigned] [Bug 42074] Layout problem with HTML5 menu item

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=42074


Eric Seidel <eric at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #112995|commit-queue?, review?      |review-
               Flag|                            |




--- Comment #24 from Eric Seidel <eric at webkit.org>  2011-12-13 23:19:57 PST ---
(From update of attachment 112995)
View in context: https://bugs.webkit.org/attachment.cgi?id=112995&action=review

Although darin encouraged you to fix more of these cases, your testing is insufficient for all these changes.  Either you should only make the changes you are testing and file bugs about the other cases, or you should test all the cases you're changing in this patch. :)  I suspect you should start with the first approach.  Alternatively, you could add FIXME's to the places you believe need these checks but are not yet tested.

> Source/WebCore/html/parser/HTMLElementStack.cpp:87
>  inline bool isListItemScopeMarker(ContainerNode* node)
>  {
>      return isScopeMarker(node)
> +        || node->hasTagName(menuTag)
>          || node->hasTagName(olTag)
>          || node->hasTagName(ulTag);
>  }

This function is directly derived from the HTML5 parsing spec.  It should be trivial to confirm if menu is a scope marker or not.

I do not see it listed here:
http://www.whatwg.org/specs/web-apps/current-work/#has-an-element-in-scope

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.