[Webkit-unassigned] [Bug 74426] [Qt] [Gardening] Remove qt-4.7 layout tests dir

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Dec 13 22:56:55 PST 2011


Csaba Osztrogonac <ossy at webkit.org> changed:

           What    |Removed                     |Added
 Attachment #119070|review?                     |review-
               Flag|                            |

--- Comment #6 from Csaba Osztrogonac <ossy at webkit.org>  2011-12-13 22:56:55 PST ---
(From update of attachment 119070)
View in context: https://bugs.webkit.org/attachment.cgi?id=119070&action=review

> Tools/Scripts/webkitpy/layout_tests/port/qt_unittest.py:-68
> -        self._assert_search_path(['qt-mac', 'qt-4.7', 'qt'], 'darwin')
> -        self._assert_search_path(['qt-win', 'qt-4.7', 'qt'], 'win32')
> -        self._assert_search_path(['qt-win', 'qt-4.7', 'qt'], 'cygwin')
> -        self._assert_search_path(['qt-linux', 'qt-4.7', 'qt'], 'linux2')
> -        self._assert_search_path(['qt-linux', 'qt-4.7', 'qt'], 'linux3')

These lines shouldn't be removed, because we should check the 
default qt_version too, which became '4.8' with this patch.
So please change qt-4.7 to qt-4.8, and I'll r+ the patch,
and land it manually, because svn-apply doesn't like
removed files in a patch.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list