[Webkit-unassigned] [Bug 74381] Upstream 3 files into WebCore/platform/blackberry

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=74381


Rob Buis <rwlbuis at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #118958|review?                     |review-
               Flag|                            |




--- Comment #2 from Rob Buis <rwlbuis at gmail.com>  2011-12-13 13:10:20 PST ---
(From update of attachment 118958)
View in context: https://bugs.webkit.org/attachment.cgi?id=118958&action=review

Looks very good, can be cleaned up a bit more I think.

> Source/WebCore/platform/blackberry/ClipboardBlackBerry.cpp:2
> + * Copyright (C) 2010 Research In Motion Limited. All rights reserved.

This was touched in 2011, may as well update that fact.

> Source/WebCore/platform/blackberry/PasteboardBlackBerry.cpp:2
> + * Copyright (C) 2009 Research In Motion Limited. All rights reserved.

This was touched in 2011, may as well update that fact.

> Source/WebCore/platform/blackberry/PasteboardBlackBerry.cpp:91
> +    String html = String::fromUTF8(BlackBerry::Platform::Clipboard::readHTML().c_str());

RefPtr<DocumentFragment> fragment could be declared here.

> Source/WebCore/platform/blackberry/PasteboardBlackBerry.cpp:96
> +        if (fragment)

Can write this like if (fragment = createFragmentFromMarkup(frame->document(), html, url, FragmentScriptingNotAllowed))

> Source/WebCore/platform/blackberry/PasteboardBlackBerry.cpp:106
> +    if (fragment) {

Can write this like if (fragment = createFragmentFromText(context.get(), text))

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.