[Webkit-unassigned] [Bug 73350] [chromium] Allow scrolling non-root layers in the compositor thread

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Dec 13 12:52:44 PST 2011


--- Comment #22 from Alexandre Elias <aelias at chromium.org>  2011-12-13 12:52:44 PST ---
Looking good, thanks.  One final concern: we should make sure that m_currentlyScrollingLayerImpl doesn't get into a bad state.

1. I'd suggest adding m_currentlyScrollingLayerImpl.clear(); to the beginning of scrollBegin().  That way we're more robust to bugs in the caller like forgetting to call ScrollEnd.
2. It could be that m_currentlyScrollingLayerImpl goes away during a commit.  I guess we could validate that it's still present in the tree in commitComplete()?

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list