[Webkit-unassigned] [Bug 74196] [chromium] Delegate scroll events to the main thread when needed

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=74196





--- Comment #3 from Adrienne Walker <enne at google.com>  2011-12-13 12:06:02 PST ---
(From update of attachment 119033)
View in context: https://bugs.webkit.org/attachment.cgi?id=119033&action=review

Other than one small thing, this is looking good to me.  Thanks for the tests!

> Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:341
> +    IntPoint contentPoint(layerImpl->screenSpaceTransform().inverse().mapPoint(viewportPoint));
> +    // The content point for non-root layers must be scaled with the page scale. Note that the
> +    // page scale delta is already embedded in each layer's screen space transform.
> +    if (layerImpl != m_scrollLayerImpl)
> +        contentPoint.scale(m_pageScale, m_pageScale);

I know you're just moving code here, but I don't follow this logic and why the scroll layer behaves differently.  Would you mind explaining why this is? Don't all layers (root or no) have the page scale applied to them?

Also, do you need to apply the page scale delta? Maybe I'd feel more comfortable if there were more tests for this function that covered page scale.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.