[Webkit-unassigned] [Bug 72715] Implement AccessKeyLabel attribute.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Dec 13 09:33:03 PST 2011
https://bugs.webkit.org/show_bug.cgi?id=72715
--- Comment #31 from Darin Adler <darin at apple.com> 2011-12-13 09:33:02 PST ---
(From update of attachment 118992)
View in context: https://bugs.webkit.org/attachment.cgi?id=118992&action=review
>> Source/WebCore/html/HTMLElement.cpp:796
>> + String accessKeyValue = getAttribute(accesskeyAttr);
>
> I'm not quite sure about this, but I think that the function to use is fastGetAttribute - getAttribute is only needed for animatable SVG attributes.
That’s correct. It’s also better to use const AtomicString& for the result of the function, otherwise there is unnecessary churn.
> Source/WebCore/html/HTMLElement.cpp:803
> + static String accessKeyLabelValue;
We don’t use variables like this that create global destructors in WebKit code. The build will fail on Mac if we do.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list