[Webkit-unassigned] [Bug 73544] [EFL] Add Web Notification feature for Efl port

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=73544





--- Comment #11 from Gyuyoung Kim <gyuyoung.kim at samsung.com>  2011-12-13 02:32:51 PST ---
(From update of attachment 118738)
View in context: https://bugs.webkit.org/attachment.cgi?id=118738&action=review

> Source/WebKit/efl/ewk/ewk_notification.cpp:81
> +void ewk_notification_show(Evas_Object* ewkView, WebCore::Notification* notification)

If ewk_notificaiton.cpp only uses ewkView object for sending signal, it looks there are no problems. However, if we need to expand new attribute in future, I think we need to make smart data for ewk_notification.cpp. Then, we can bind it with ewkView object as Ewk_Frame_Smart_Data.

> Source/WebKit/efl/ewk/ewk_notification.h:43
> + * Callback call after user approve display a notification.

approve -> approves ?

> Source/WebKit/efl/ewk/ewk_notification.h:64
> + * Make a ondisplay callback call for JavaScript after notification is displayed

%s/a/an/g

> Source/WebKit/efl/ewk/ewk_notification.h:73
> + * Make a onclick callback call for JavaScript after notification is clicked

ditto.

> Source/WebKit/efl/ewk/ewk_notification.h:82
> + * Make a onclose callback call for JavaScript after notification is closed

ditto.

> Source/WebKit/efl/ewk/ewk_notification.h:99
> +WebCore::NotificationPresenter* ewk_notification_presenter_get(const Evas_Object* ewkView);

This is internal function, right? We should not open internal function to outer.

> Source/WebKit/efl/ewk/ewk_notification.h:100
> +void ewk_notification_show(Evas_Object* ewkView, WebCore::Notification* notification);

ditto.

> Source/WebKit/efl/ewk/ewk_notification.h:101
> +void ewk_notification_html_show(Evas_Object* ewkView, WebCore::Notification* notification);

ditto.

> Source/WebKit/efl/ewk/ewk_notification.h:102
> +void ewk_notification_cancel(Evas_Object* ewkView, WebCore::Notification* notification);

ditto.

> Source/WebKit/efl/ewk/ewk_notification.h:103
> +void ewk_notification_request_permission(Evas_Object* ewkView, const char* domain);

ditto.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.