[Webkit-unassigned] [Bug 73194] [BlackBerry] Add notification support for the BlackBerry port

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Dec 13 00:55:52 PST 2011


--- Comment #19 from Nikolas Zimmermann <zimmermann at kde.org>  2011-12-13 00:55:52 PST ---
(In reply to comment #17)
> (From update of attachment 118335 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=118335&action=review
> >> Source/WebKit/blackberry/WebCoreSupport/NotificationPresenterImpl.cpp:36
> >> +NotificationPresenter* NotificationPresenterImpl::instance()
> > 
> > Why is this named *Impl - we generally try to avoid this idiom in WebCore, but as this is WebKit it might be fine. Do you plan to add more *Impl.cpp named files?
> There is already another header file: ./Source/WebCore/notifications/NotificationPresenter.h, If rename NotificationPresenterImpl.h to NotificationPresenter.h, it will conflict with the one in WebCore. So, I keep the original names.

Oh okay, these are the information that are supposed to be in the ChangeLog. Next time someone looks at this, wondering why it was named this way :-)

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list