[Webkit-unassigned] [Bug 70107] Custom written CSS lexer

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=70107





--- Comment #22 from Oliver Hunt <oliver at apple.com>  2011-12-13 00:05:18 PST ---
(From update of attachment 118748)
View in context: https://bugs.webkit.org/attachment.cgi?id=118748&action=review

> Source/WebCore/css/CSSParser.cpp:7460
> +        if (UNLIKELY(*data == quote)) {

We don't take this path if we've reached the end of the buffer as *data == 0

> Source/WebCore/css/CSSParser.cpp:7464
> +        if (UNLIKELY(*data < 14 && *data > 9 && *data != 11)) {

This is checking for *data == 10, 12 or 13 so we don't match 0 here.

> Source/WebCore/css/CSSParser.cpp:7469
> +        if (LIKELY(data[0] != '\\'))

data[0] is 0 (because we're at the end of the buffer) so we take this path, increment data, and go back to the head of the loop

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.