[Webkit-unassigned] [Bug 73194] [BlackBerry] Add notification support for the BlackBerry port

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=73194





--- Comment #17 from Robin Qiu <robin.qiu at torchmobile.com.cn>  2011-12-12 19:49:51 PST ---
(From update of attachment 118335)
View in context: https://bugs.webkit.org/attachment.cgi?id=118335&action=review

>> Source/WebKit/blackberry/WebCoreSupport/NotificationPresenterImpl.cpp:36
>> +NotificationPresenter* NotificationPresenterImpl::instance()
> 
> Why is this named *Impl - we generally try to avoid this idiom in WebCore, but as this is WebKit it might be fine. Do you plan to add more *Impl.cpp named files?

There is already another header file: ./Source/WebCore/notifications/NotificationPresenter.h, If rename NotificationPresenterImpl.h to NotificationPresenter.h, it will conflict with the one in WebCore. So, I keep the original names.

>>> Source/WebKit/blackberry/WebCoreSupport/NotificationPresenterImpl.cpp:121
>>> +    return;
>> 
>> Unncessary.
> 
> I added this according Daniel's comment. :P

I added this according Daniel's comment. :P

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.