[Webkit-unassigned] [Bug 74169] Upstream 3 files into WebCore/platform/blackberry

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=74169


Rob Buis <rwlbuis at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #118722|review?                     |review-
               Flag|                            |




--- Comment #11 from Rob Buis <rwlbuis at gmail.com>  2011-12-12 07:14:22 PST ---
(From update of attachment 118722)
View in context: https://bugs.webkit.org/attachment.cgi?id=118722&action=review

Some nits left, nearly there :)

> Source/WebCore/platform/blackberry/GeolocationServiceBlackBerry.cpp:48
> +    m_geolocation->frame()->loader()->client()->didCreateGeolocation(m_geolocation);

It seems safer to test for m_geolocation->frame() being not null, like in GeolocationServiceBlackBerry::startUpdating.

> Source/WebCore/platform/blackberry/GeolocationServiceBlackBerry.cpp:106
> +                                                          true, // providesAltititude

This is not a valid word, it should be "providesAltitude".

> Source/WebCore/platform/blackberry/PageClientBlackBerry.h:51
> +    virtual bool shouldPluginEnterFullScreen(WebCore::PluginView*, const char*) = 0;

The second param name should be provided, I can't tell what it is doing without the name.

> Source/WebCore/platform/blackberry/PageClientBlackBerry.h:52
> +    virtual void didPluginEnterFullScreen(WebCore::PluginView*, const char*) = 0;

Ditto.

> Source/WebCore/platform/blackberry/PageClientBlackBerry.h:53
> +    virtual void didPluginExitFullScreen(WebCore::PluginView*, const char*) = 0;

Ditto.

> Source/WebCore/platform/blackberry/PageClientBlackBerry.h:54
> +    virtual void onPluginStartBackgroundPlay(WebCore::PluginView*, const char*) = 0;

Ditto.

> Source/WebCore/platform/blackberry/PageClientBlackBerry.h:55
> +    virtual void onPluginStopBackgroundPlay(WebCore::PluginView*, const char*) = 0;

Ditto.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.