[Webkit-unassigned] [Bug 73544] [EFL] Add Web Notification feature for Efl port

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=73544





--- Comment #7 from Gyuyoung Kim <gyuyoung.kim at samsung.com>  2011-12-10 01:34:56 PST ---
(From update of attachment 118556)
View in context: https://bugs.webkit.org/attachment.cgi?id=118556&action=review

> Source/WebKit/efl/ChangeLog:8
> +        This is a implementation about web notification for efl

s/a/an/g

> Source/WebKit/efl/ewk/ewk_view.h:2298
> +EAPI void ewk_view_notification_permission_callback(const Evas_Object *o, Eina_Bool permitted, const char* domain);

I don't like to implement new independent feature to ewk_view. I think it is better to add new files (e.g ewk_notification.cpp | h) for this feature. I think you can move ewk_view_notificaiton_xxx functions to ewk_notification.cpp by using Ewk_Notification struct.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.