[Webkit-unassigned] [Bug 73194] [BlackBerry] Add notification support for the BlackBerry port

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=73194


Nikolas Zimmermann <zimmermann at kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |zimmermann at kde.org




--- Comment #12 from Nikolas Zimmermann <zimmermann at kde.org>  2011-12-10 00:15:02 PST ---
Hi Dan,

(In reply to comment #5)
> > Source/WebKit/blackberry/WebCoreSupport/NotificationPresenterImpl.cpp:73
> > +        message = notification->contents().title() + ": " + notification->contents().body();
> 
> We should use makeString() (*) here:
> 
> message = makeString(notification->contents().title(), ": ", notification->contents().body());
> 
> (*) Defined in JavaScriptCore/wtf/text/StringConcatenate.h: <http://trac.webkit.org/browser/trunk/Source/JavaScriptCore/wtf/text/StringConcatenate.h?rev=98624#L621>.
Just a side note: We have an optimized operator+ template version, that I worked on some months ago, that delivers the same performance as using makeString. In fact StringAppend<T, StringAppend<T> > operator+(StringAppend&) uses makeString internally. If these are WTF::Strings, using notifcation->contents().title + ": " .. is completely fine, this won't lead to a realloc, instead the final string will be built using makeString().

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.