[Webkit-unassigned] [Bug 73668] Upstream BlackBerry API backing store files

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=73668


Daniel Bates <dbates at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #118601|review?                     |review+, commit-queue-
               Flag|                            |




--- Comment #10 from Daniel Bates <dbates at webkit.org>  2011-12-09 13:52:37 PST ---
(From update of attachment 118601)
View in context: https://bugs.webkit.org/attachment.cgi?id=118601&action=review

> Source/WebKit/blackberry/Api/BackingStore.cpp:1957
> +void BackingStorePrivate::actualVisibleSizeChanged(const Platform::IntSize& size)

We should ultimately remove this method since it has an empty implementation. We can do this in a follow up bug.

> Source/WebKit/blackberry/Api/BackingStore.cpp:2054
> +    static int tw = 0;

I would write lines 2054-2056 as:

static int tileWidth = BlackBerry::Platform::Graphics::Screen::landscapeWidth();

> Source/WebKit/blackberry/Api/BackingStore.cpp:2062
> +    static int th = 0;

I would use a similar approach here.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.