[Webkit-unassigned] [Bug 70810] nameNodeListCache should be invalidated when name attribute changes/modified.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=70810


Ryosuke Niwa <rniwa at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #118617|review+, commit-queue+      |review-, commit-queue-
               Flag|                            |




--- Comment #29 from Ryosuke Niwa <rniwa at webkit.org>  2011-12-09 12:53:28 PST ---
(From update of attachment 118617)
View in context: https://bugs.webkit.org/attachment.cgi?id=118617&action=review

> LayoutTests/fast/dom/getelementsbyname-invalidation-cache.html:35
> +    document.getElementById('testElement').setAttribute('name', 'changed-name');
> +    shouldBe("document.querySelector('" + tagName + "'); document.getElementsByName('fullname').length", "1");

Wait... what's the point of querySelector here? You should be doing document.querySelector('" + tagName + "').setAttribute('name', 'changed-name') here instead.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.