[Webkit-unassigned] [Bug 70810] nameNodeListCache should be invalidated when name attribute changes/modified.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=70810





--- Comment #24 from Arko Saha <nghq36 at motorola.com>  2011-12-09 12:34:26 PST ---
(In reply to comment #23)
> (From update of attachment 118594 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=118594&action=review
> 
> >>> LayoutTests/fast/dom/getelementsbyname-invalidation-cache.html:32
> >>> +    shouldBeTrue("document.getElementsByName('fullname').length != oldLength");
> >> 
> >> You could create a function like createElement() that takes a tag name and returned the element. That way, shouldBeTrue will include the tag name and you don't need to add extra lines by debug.
> > 
> > I am facing some problem here.
> > Suppose, getElement(tagName) is the function which return me the element based on the tag name. 
> > Now when we do shouldBeTrue("getElement(); document.getElementsByName('fullname').length != oldLength") it gives "PASS getElement(); document.getElementsByName('fullname').length != oldLength is true" in the expected output rather giving me the actual tag name in the expected result.
> > 
> > Can you please correct me if I am missing something here. Thanks.
> 
> You can do:
> shouldBeTrue("CreateTwoElements('" + tagName + "); document.getElementsByName('fullname').length", "2");
> shouldBeTrue("document.querySelector("' + tagName + '"); document.getElementsByName('fullname').length", "1");
> // Remove those two elements here.

Darin/Ryosuke thanks for the help. I will upload the modified patch.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.