[Webkit-unassigned] [Bug 53378] [chromium] svg/clip-path/clip-in-mask.svg fails on Windows and Linux

Fri Dec 9 11:09:34 PST 2011

https://bugs.webkit.org/show_bug.cgi?id=53378

Tony Chang <tony at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #118554|review?                     |review-
               Flag|                            |

--- Comment #17 from Tony Chang <tony at chromium.org>  2011-12-09 11:09:34 PST ---
(From update of attachment 118554)
View in context: https://bugs.webkit.org/attachment.cgi?id=118554&action=review

>>> Source/WebCore/ChangeLog:9
>>> +        all complex clipping (including text and/or masks) to fail.
>> 
>> Can you explain what the bug was and how this fixes it?  I don't know this code very well and it's hard for me to tell if the new code is correct.
> 
> The bug was in Skia's clipping code's handling of coordinate transformations. The method beginLayerClippedToImage was taking rectangle coordinates in one local coordinate space, but it was applying them in a different one because of the delay between the time it is called and the actual application occurs in applyClipFromImage. The fix translates the coordinates passed to beginLayerClippedToImage to absolute ones, so that they are not affected by any change in the transform matrix, and makes sure that applyClipFromImage clears the matrix before applying the clip layer to correctly apply the absolute coordinates.

Please include this in the ChangeLog, otherwise, this patch seems fine.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.