[Webkit-unassigned] [Bug 74178] Add new CSS nth-children parsing tests

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=74178


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #118570|review?                     |review+
               Flag|                            |




--- Comment #2 from Darin Adler <darin at apple.com>  2011-12-09 09:35:25 PST ---
(From update of attachment 118570)
View in context: https://bugs.webkit.org/attachment.cgi?id=118570&action=review

> Source/WebCore/css/CSSParser.cpp:8092
>      // The tokenizer checks for the construct of an+b.
>      // nth can also accept "n", "odd" or "even" but should not accept any other token.
> -    return equalIgnoringCase(token, "odd") || equalIgnoringCase(token, "even") || equalIgnoringCase(token, "n");
> +    return equalIgnoringCase(token, "odd") || equalIgnoringCase(token, "even")
> +        || equalIgnoringCase(token, "n") || equalIgnoringCase(token, "-n");

The comment now does not match the code. There is no clue here why "-n" is something we need to allow here.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.